Review Request: Achievements 2: LongLongPropertyWidgetItem

[Arjen Hiemstra]

> On July 11, 2011, 1:10 p.m., Laszlo Papp wrote:
> > creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp, line 78
> > <http://git.reviewboard.kde.org/r/101908/diff/3/?file=26708#file26708line78>
> >
> >     I would probably write out the "value" variable as well, thus we know what value caused the issue (number is not needed since that is supposed to be zero). It would be one more information while debugging. i.e.: DEBUG_TEXT( QString("LongLongPropertyWidgetItem: Could not convert the string value %1 to qlonglong").arg(value) ); or something like this. :)

Actually, you can use DEBUG_TEXT2("String with %1 arg", arg) since you only need one argument anyway.


- Arjen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101908/#review4595
-----------------------------------------------------------


On July 11, 2011, 1:15 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101908/
> -----------------------------------------------------------
> 
> (Updated July 11, 2011, 1:15 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Add a PropertyWidgetItem to edit qlonglong values in the creator. Needed by the Achievement class.
> 
> 
> Diffs
> -----
> 
>   creator/plugins/docks/propertiesdock/CMakeLists.txt 05c5242 
>   creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.h PRE-CREATION 
>   creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101908/diff
> 
> 
> Testing
> -------
> 
> Tested with the Achievement and Statistic class. When the value is out of the limit, it is set to 0.
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110712/60864f72/attachment.htm