Review Request: Achievements 3: AchievementsAsset

Laszlo Papp lpapp at kde.org
Tue Jul 12 05:05:40 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101909/#review4627
-----------------------------------------------------------



engine/assets/other/achievements/achievementsasset.cpp
<http://git.reviewboard.kde.org/r/101909/#comment4051>

    isEmpty() ?


- Laszlo


On July 11, 2011, 12:32 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101909/
> -----------------------------------------------------------
> 
> (Updated July 11, 2011, 12:32 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Adds the AchievementsAsset class, which cares about the Achievement objects and saves them in a file. Also add mime-type information for this file type.
> 
> Note: This patch also adds the file "achievements_template.gluonachievements" at engine/assets/other/achievements/. As this file is empty, ReviewBoard doesn't show it.
> 
> 
> Diffs
> -----
> 
>   creator/x-gluon-mimetypes.xml 378876d 
>   engine/assets/CMakeLists.txt b8c087b 
>   engine/assets/other/achievements/CMakeLists.txt PRE-CREATION 
>   engine/assets/other/achievements/achievementsasset.h PRE-CREATION 
>   engine/assets/other/achievements/achievementsasset.cpp PRE-CREATION 
>   engine/gluon_engine_export.h 17fc00c 
> 
> Diff: http://git.reviewboard.kde.org/r/101909/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110712/c14ad955/attachment-0001.htm 


More information about the Gluon mailing list