Review Request: Achievements 2: LongLongPropertyWidgetItem

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101908/#review4581
-----------------------------------------------------------



creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp
<http://git.reviewboard.kde.org/r/101908/#comment3989>

    1) You confused the longlong value with the long value. What you wrote is the long max value. 
    
    2) You can include limits.h and use  LLONG_MAX without hard coded values.



creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp
<http://git.reviewboard.kde.org/r/101908/#comment3990>

    Mmm, I told on IRC that, I think it might be a good idea to report the issue with a gluon debug message if the conversion somehow failed. It should not fail with the proper range value, but a conditional debug message should not hurt in order to make the library more talkative in case of errors.


- Laszlo


On July 10, 2011, 10:48 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101908/
> -----------------------------------------------------------
> 
> (Updated July 10, 2011, 10:48 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Add a PropertyWidgetItem to edit qlonglong values in the creator. Needed by the Achievement class.
> 
> 
> Diffs
> -----
> 
>   creator/plugins/docks/propertiesdock/CMakeLists.txt 05c5242 
>   creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.h PRE-CREATION 
>   creator/plugins/docks/propertiesdock/propertywidgetitems/longlongpropertywidgetitem.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101908/diff
> 
> 
> Testing
> -------
> 
> Tested with the Achievement and Statistic class. When the value is out of the limit, it is set to 0.
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110710/f06d4bbe/attachment.htm