Review Request: Achievements 1: The Achievement class

Laszlo Papp lpapp at kde.org
Sun Jul 10 17:55:17 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101900/#review4574
-----------------------------------------------------------

Ship it!


- Laszlo


On July 10, 2011, 3:35 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101900/
> -----------------------------------------------------------
> 
> (Updated July 10, 2011, 3:35 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> This is the first patch in a row of patches. It adds the Achievement class and makes the value property of the AbstractStatistic class public, as Achievement needs it. Achievements will contain information about an Achievement, including the connection to one statistic. Achievements will be managed by the AchievementsAsset class.
> 
> 
> Diffs
> -----
> 
>   engine/CMakeLists.txt e8764f5 
>   engine/abstractstatistic.h 494032f 
>   engine/achievement.h PRE-CREATION 
>   engine/achievement.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101900/diff
> 
> 
> Testing
> -------
> 
> Compiles. I tested it, too, but before rebasing it upon master.
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110710/f7614559/attachment.htm 


More information about the Gluon mailing list