Review Request: Achievements 1: The Achievement class

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101900/#review4555
-----------------------------------------------------------



engine/achievement.h
<http://git.reviewboard.kde.org/r/101900/#comment3963>

    I personally like to separate the next public/protected/private section with a line break, like you do in this file before the private.



engine/achievement.cpp
<http://git.reviewboard.kde.org/r/101900/#comment3962>

    You do not need to use engine/statistic.h, just statistic.h



engine/achievement.cpp
<http://git.reviewboard.kde.org/r/101900/#comment3964>

    Note: Interesting this "achieved" method has a similar format (2 ifS with one statement and one statement separately) to setStatistics() method, but different usage of "{, }" and line breaks.
    
    I personally prefer this way though, but any consistency is good. :)


Thanks it is much easier to review and I have more sake to grab it. :) If you fix these really really minor issues, I think it is fine with me.

- Laszlo


On July 9, 2011, 12:56 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101900/
> -----------------------------------------------------------
> 
> (Updated July 9, 2011, 12:56 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> This is the first patch in a row of patches. It adds the Achievement class and makes the value property of the AbstractStatistic class public, as Achievement needs it. Achievements will contain information about an Achievement, including the connection to one statistic. Achievements will be managed by the AchievementsAsset class.
> 
> 
> Diffs
> -----
> 
>   engine/CMakeLists.txt e8764f5 
>   engine/abstractstatistic.h 494032f 
>   engine/achievement.h PRE-CREATION 
>   engine/achievement.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101900/diff
> 
> 
> Testing
> -------
> 
> Compiles. I tested it, too, but before rebasing it upon master.
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110709/30437b53/attachment.htm