Review Request: Add required classes, and extend existing classes to fulfill dependencies for AllGameItemsModel
Shantanu Tushar Jha
jhahoneyk at gmail.com
Wed Jul 6 18:32:53 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101868/
-----------------------------------------------------------
Review request for Gluon.
Summary
-------
This patch renames GameDetail to GameDetailsJob, Rating to RatingJob. It also extends both classes, adding more functionality. Also, renamed few signals for consistency.
Diffs
-----
player/lib/CMakeLists.txt f925fdf
player/lib/gamedetail.h f179b47
player/lib/gamedetail.cpp eb974b7
player/lib/gamedetailsjob.h PRE-CREATION
player/lib/gamedetailsjob.cpp PRE-CREATION
player/lib/models/gameitemsmodel.cpp cecaad1
player/lib/rating.h a614281
player/lib/rating.cpp 941062d
player/lib/ratingjob.h PRE-CREATION
player/lib/ratingjob.cpp PRE-CREATION
player/lib/serviceprovider.h 8844b7f
player/lib/serviceprovider.cpp 21313eb
Diff: http://git.reviewboard.kde.org/r/101868/diff
Testing
-------
Syntactically correct, compiles successfully. Actual testing to be done when AllGameItemsModel will be integrated.
Thanks,
Shantanu Tushar
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110706/b2ed62e9/attachment-0001.htm
More information about the Gluon
mailing list