Review Request: Add Category and NewGame classes

[Laszlo Papp]

> On July 1, 2011, 3:43 p.m., Arjen Hiemstra wrote:
> > player/lib/category.h, line 58
> > <http://git.reviewboard.kde.org/r/101816/diff/1/?file=25763#file25763line58>
> >
> >     Personally, I prefer the following order in general:
> >     
> >     Public
> >     Public Slots
> >     Signals
> >     Protected
> >     Protected Slots
> >     Private
> >     Private Slots
> >     
> >     Makes it easier to simply read the header to find out what methods it contains and makes it easier to skip over the irrelevant ones. (i.e., private always and protected when you're not inheriting.)
> >     
> >     Also, wouldn't these be better served by using Q_PRIVATE_SLOT ?
> 
> Shantanu Tushar Jha wrote:
>     I have read concerns about Q_PRIVATE_SLOT not being documented and hence they should be avoided. (Refer http://lists.trolltech.com/qt-interest/2008-04/msg00348.html, first comment from Thiago). Is it ok to be used?
> 
> Arjen Hiemstra wrote:
>     If its changed there is a lot of KDE code that is going to break, for example https://projects.kde.org/projects/kde/kdelibs/repository/revisions/master/entry/kdecore/jobs/kjob.h . So yes, I would say it is safe. :)

Yes, for now. Note: I think it is good in /my/ :) opinion to establish the proper solution at some point with different *_p.h files in the future.


- Laszlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101816/#review4294
-----------------------------------------------------------


On July 2, 2011, 2:29 p.m., Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101816/
> -----------------------------------------------------------
> 
> (Updated July 2, 2011, 2:29 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Category's job is to fetch list of categories from the server.
> NewGame takes a game name and a category, and then creates a new game on the server, returning the ID of newly created game.
> 
> 
> Diffs
> -----
> 
>   player/lib/CMakeLists.txt 53c0f0a 
>   player/lib/category.h PRE-CREATION 
>   player/lib/category.cpp PRE-CREATION 
>   player/lib/remotegame.h PRE-CREATION 
>   player/lib/remotegame.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101816/diff
> 
> 
> Testing
> -------
> 
> Both classes function as expected when used.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110703/9837d39c/attachment-0001.htm