Review Request: Proposal how to fix a problem I have with ObjectTreeBuilder

[Arjen Hiemstra]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103464/#review9076
-----------------------------------------------------------


"This patch assumes that all objects in d->objects don't have any parents yet."

This is partly correct - all items that are in d->objects do not have parents since they are considered to be top level items. 

They do have children, however, which means the current code breaks any reference lookup in children that should not be done
from the project. The reason it does work for Invaders is because d->project is set to the first top level item encountered when
no explicit project is passed in ObjectTreeBuilder's constructor. Thus, the second code path is triggered which successfully finds
the object. Maybe you can explain the problem in a bit more detail so we can come up with a solution?

- Arjen Hiemstra


On Dec. 18, 2011, 10:30 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103464/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2011, 10:30 p.m.)
> 
> 
> Review request for Gluon and Arjen Hiemstra.
> 
> 
> Description
> -------
> 
> This patch assumes that all objects in d->objects don't have any parents yet. If this is wrong, the patch is wrong. I don't quite understand all that parser stuff, so I didn't check this myself.
> 
> 
> Diffs
> -----
> 
>   core/gdl/objecttreebuilder.cpp 4dcefa8 
> 
> Diff: http://git.reviewboard.kde.org/r/103464/diff/diff
> 
> 
> Testing
> -------
> 
> - My problem is solved
> - Invaders still loads into creator and can be played.
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111219/27998782/attachment.html>