Review Request: Make findObjectByName recursive and virtual

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103339/#review8738
-----------------------------------------------------------



core/tests/gluonobjecttest.cpp
<http://git.reviewboard.kde.org/r/103339/#comment7340>

    Even if you do not make a separate testGrandChildByName-like method, it would be nice you do not mix up all the QCOMPARE statements in a bunch by losing the logical flow.
    
    I would prefer having the child tests first, and when the compares are done, adding the grand childrens, and the relevant granchildren tests. It would be better separated, and thereby better readable.
    
    Also, it is very hard to read without spaces. You could probably use spaces between the logical units.
    


- Laszlo Papp


On Dec. 5, 2011, 9:56 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103339/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2011, 9:56 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Description
> -------
> 
> That's needed for a asset load-on-demand system.
> Additionally, some changes on findGlobalItemByName.
> 
> 
> Diffs
> -----
> 
>   core/gluonobject.h 8fc3bc4 
>   core/gluonobject.cpp 2ac648c 
>   core/tests/gluonobjecttest.cpp ef3d2c7 
> 
> Diff: http://git.reviewboard.kde.org/r/103339/diff/diff
> 
> 
> Testing
> -------
> 
> extended the existing test
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111205/ebc70fad/attachment-0001.html>