Review Request: Use load/unload in the {Statistic, Achievement}Asset
Dan Leinir Turthra Jensen
admin at leinir.dk
Mon Dec 5 22:18:44 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103341/#review8737
-----------------------------------------------------------
Looks good but for these two :)
engine/assets/other/achievements/achievementsasset.cpp
<http://git.reviewboard.kde.org/r/103341/#comment7338>
You should really use a copy of children(), as it might change while you're working on it
engine/assets/other/statistics/statisticsasset.cpp
<http://git.reviewboard.kde.org/r/103341/#comment7339>
see above ;)
- Dan Leinir Turthra Jensen
On Dec. 5, 2011, 10:03 p.m., Felix Rohrbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103341/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2011, 10:03 p.m.)
>
>
> Review request for Gluon.
>
>
> Description
> -------
>
> Additionally, call GDLSerializer::read with gameProject() as third parameter. This should fix achievements with the new gdl parser :)
>
>
> Diffs
> -----
>
> engine/assets/other/achievements/achievementsasset.h a7943cb
> engine/assets/other/achievements/achievementsasset.cpp 4813df8
> engine/assets/other/statistics/statisticsasset.h f7f2684
> engine/assets/other/statistics/statisticsasset.cpp c1d90fe
>
> Diff: http://git.reviewboard.kde.org/r/103341/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Felix Rohrbach
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111205/a18209e8/attachment.html>
More information about the Gluon
mailing list