Review Request: Achievements 8: Make use of the AchievementsManager and the ProjectMetaData classes.

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102245/#review6081
-----------------------------------------------------------


I made the player library a bit more consistent. Please check how much overhead the merging would cause you. Feel free to revert that commit and we can do afterwards, if it is too much hazzle for you. I hope it helps with not having any in-between inconsistency that way.

- Laszlo


On Aug. 27, 2011, 7:53 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102245/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2011, 7:53 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Now, the user should be able to create games with simple statistics/achievements.
> 
> 
> Diffs
> -----
> 
>   engine/game.cpp 9495909 
>   engine/gameproject.cpp 1fc2eb4 
>   engine/projectmetadata.h a8b3758 
>   engine/projectmetadata.cpp 3b36771 
>   player/kdeext/gamedetailsoverlay.h 99923a2 
>   player/kdeext/gamedetailsoverlay.cpp b6f525c 
>   player/kdeext/gamesoverlay.cpp d468186 
>   player/lib/models/achievementsmodel.h 3df946e 
>   player/lib/models/achievementsmodel.cpp e1ebad0 
>   player/lib/models/commentsmodel.cpp 4572f23 
>   player/lib/models/gameitemsmodel.h d2e3604 
>   player/lib/models/gameitemsmodel.cpp c4c977c 
>   player/lib/models/gameviewitem.h a017862 
>   player/lib/models/gameviewitem.cpp 64dd46a 
> 
> Diff: http://git.reviewboard.kde.org/r/102245/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110827/2235a915/attachment-0001.html>