Review Request: Achievements 9: Generate the metadata files for the example games.

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102259/#review5744
-----------------------------------------------------------


How about using projectFilePath in the meta file ? It would be more clear (at least to me :p). It does not bring any doubt either whether or not it is the project root. From the engine/gameproject.h -> const QString projectFilename( "game.gluonproject" ); -> According to this, I think it would also be more consistent to the rest.

Other than that, I do not have any other issues with it. :)

- Laszlo


On Aug. 9, 2011, 9:14 a.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102259/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2011, 9:14 a.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Together with patch 8, these metadata files will be used by the player applications to show information about a game.
> 
> 
> Diffs
> -----
> 
>   player/examples/apocalypse.gluon/game.gluonmeta PRE-CREATION 
>   player/examples/ball.gluon/game.gluonmeta PRE-CREATION 
>   player/examples/invaders.gluon/game.gluonmeta PRE-CREATION 
>   player/examples/jumpnbump.gluon/game.gluonmeta PRE-CREATION 
>   player/examples/pong.gluon/game.gluonmeta PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102259/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110816/e82b0f7a/attachment.html>