Review Request: Achievements 8: Make use of the AchievementsManager and the ProjectMetaData classes.

[Dan Leinir Turthra Jensen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102245/#review5491
-----------------------------------------------------------


That's all i can see - otherwise it looks good to me :)


player/kdeext/gamedetailsoverlay.h
<http://git.reviewboard.kde.org/r/102245/#comment4925>

    You probably want to not have commented-out code here...



player/lib/models/gameviewitem.cpp
<http://git.reviewboard.kde.org/r/102245/#comment4926>

    When writing private classes like this, you don't need to use the m_ prefix, as that's what d-> really signifies... They are still members, but you don't need to mentally hide them in this manner. If you look through the other pimpls in Gluon, you'll see that they also don't have the prefix.


- Dan Leinir Turthra


On Aug. 7, 2011, 3:32 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102245/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2011, 3:32 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Now, the user should be able to create games with simple statistics/achievements.
> 
> 
> Diffs
> -----
> 
>   engine/game.cpp 9495909 
>   engine/gameproject.cpp 1fc2eb4 
>   player/kdeext/gamedetailsoverlay.h 99923a2 
>   player/kdeext/gamedetailsoverlay.cpp b6f525c 
>   player/kdeext/gamesoverlay.cpp d468186 
>   player/lib/models/achievementsmodel.h 3df946e 
>   player/lib/models/achievementsmodel.cpp e1ebad0 
>   player/lib/models/commentsmodel.cpp 4572f23 
>   player/lib/models/gameitemsmodel.h d2e3604 
>   player/lib/models/gameitemsmodel.cpp c4c977c 
>   player/lib/models/gameviewitem.h a017862 
>   player/lib/models/gameviewitem.cpp 64dd46a 
> 
> Diff: http://git.reviewboard.kde.org/r/102245/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20110808/6e0e3cb9/attachment.html>