[gcompris-devel] [New release 8.3.6 and 8.4.5]

[Bruno Coudoin]

Le dimanche 18 mai 2008 à 18:57 +0200, Lars Vogdt a écrit :
> Hi Bruno
> 
> I successfully compiled gcompris 8.4.5 for openSUSE 10.1 - 11.0 but the 
> compiler on 11.0 found two missing function prototypes. The first fix 
> was easy:
> 
> Index: gcompris-8.4.5/src/gcompris/gcompris.c
> ===================================================================
> --- gcompris-8.4.5.orig/src/gcompris/gcompris.c
> +++ gcompris-8.4.5/src/gcompris/gcompris.c
> @@ -68,7 +68,7 @@ static gint board_widget_key_press_callb
>                         gpointer     client_data);
>  void gc_terminate(int signum);
>  static void single_instance_release();
> -
> +void gc_im_init(GtkWidget *window);
>  /*
>   * For the Activation dialog
>   */

You got a fix but the proper one is to change the file gcompris_im.h
which as an incomplete definition. Obviously, the compiler was buggy not
to report it before.

> The second one looks a bit confusing to me - but I didn't find 
> the "threeDdisplay" function anywhere else - and so the parameters 
> would be useless. But I hope you get a better solution for this one:
> 
> Index: gcompris-8.4.5/src/boards/maze.c
> ===================================================================
> --- gcompris-8.4.5.orig/src/boards/maze.c
> +++ gcompris-8.4.5/src/boards/maze.c
> @@ -986,7 +986,7 @@ static gint tux_event(GnomeCanvasItem *i
> 
>  static gint target_event(GnomeCanvasItem *item, GdkEvent *event, 
> gpointer data)
>  {  if (event->type!=GDK_BUTTON_PRESS) return FALSE;
> - threeDdisplay(position[ind][0],position[ind][1]);
> + threeDdisplay();
>   return FALSE;
>  }

I am also confused but your fix is correct. The threeDdisplay function
does not requires parameters at all. 

I'll commit this asap.

-- 
Bruno Coudoin
http://gcompris.net Free educational software for kids
http://toulibre.org Logiciel Libre à Toulouse