[gcompris-devel] shapegame patch

[Bruno Coudoin]

Great, I changed the value to 100 and commited.
I am very happy to close this bug, thanks a lot ;)

Bruno.

le jeu 04-04-2002 à 12:38, Ehreth Imre a écrit :
> Hi
> 
> On Wed, 2002-04-03 at 18:28, Bruno Coudoin wrote:
> > 
> > Great, you fixed a long standing bug in gcompris. Thanks a lot for that.
> > 
> > In your implementation, there is no way to put back an item in the list
> > once it has be 'moved'.
> You are right. The problem is that to big distance from the target is
> allowed. The paremeter passed to find_closest_shape should be 100
> instead of 1000 (near shapegame.c:734).
> 
> > Is this wanted and if so do other people here think it is better or
> > worse than before ?
> > 
> I don't know if it is wanted or not. But lowering the maximum distance
> solves this. Maybe the limit could be even smaller.
> 
> Imre
> 
> > Bruno.
> > 
> > le mer 03-04-2002 à 15:17, Ehreth Imre a écrit :
> > > Hello
> > > 
> > >   I promised I will hunt problems. I have found some (possible) in
> > > shapegame:
> > > 
> > >   * The closest target is not always correct. (There was a typo in
> > > find_closest_shape)
> > > 
> > >   * When in the puzzle board a piece of puzzle is grabbed, the image is
> > > made smaller but by leaving its center at the target point. So the
> > > pointer is far from the image and when the closest target is looked up
> > > the position of the pointer is checked. This can be misleading for small
> > > childrens. I have made modifications to place the picture under the
> > > pointer. (I have made this only for images)
> > > 
> > > I have created and attached a patch against the latest version found at
> > > anoncvs. If you like it please apply it.
> > > 
> > > Beast regards
> > >    Imre Ehreth
> > > 
> > > PS: I hope I will have time to make Hungarian translation
> > > 
> > > ----
> > > 
> > 
> 
> _______________________________________________
> gcompris-devel mailing list
> gcompris-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gcompris-devel