[FreeNX-kNX] Two critical path/sourcing errors in printer/file sharing in freenx 0.7.1

[Jeffrey J. Kosowsky]

Forwarding this (along with several other postings) to the list per
Fabian's suggestion... Note: I have also previously posted a copy to
the freenx-devel list.

Jeffrey J. Kosowsky wrote at about 23:54:27 -0500 on Sunday, December 9, 2007:
 > Fabian,
 > In updating to 0.7.1, I found the following two bugs related to the
 > fact that certain shell variables are not propagated properly:
 > 
 > 1. In nxnode, you added logic to the subroutine startsession" to set
 >    the values for COMMAND_SMBMOUNT and COMMAND_SMBUMOUNT.
 >    However, these shell variables are actually used in the subroutines
 >    cmd_node_smbmount and node_umount_smb.
 >    Since these are independent routines called from another
 >    subroutine, the values set in startsession are not present when
 >    they are needed in the other routines.
 > 
 >    I got around this by adding a kludge to the head of nxnode to
 >    basically repeat the logic of startsession.
 > 
 >    Alternatively, one could store the value in a temp file or as part
 >    of the string in the 'options' file.
 > 
 > 2. The variable ENABLE_FOOMATIC is exported in nxdialog and then
 >    referenced in nxprint (which is called from nxdialog). However, the
 >    variable ENABLE_FOOMATIC is actually set in nxloadconfig but is not
 >    sourced in nxdialog. Hence, it shows up as the null string so that
 >    the foomatic if clause in nxprint is never executed.
 > 
 >    Presumably, this also would effect the variable COMMAND_FOOMATIC
 >    though in nxprint the statement
 >    [ -z $COMMAND_FOOMATIC" ] && COMMAND_FOOMATIC="foomatic-ppdfile"
 >    masks the problem
 > 
 > Hope this is helpful and looking forward to seeing 0.7.2 and beyond!
 > 
 > Regards,
 > Jeff