[FreeNX-kNX] bugs in freenx code with regard to suspend-resume

[Sunil]

Some more (good news) on the reliability of
suspend/resume of freenx:

1. the trap at line : 683 in nxserver

trap server_nxnode_exit_func EXIT

fires unnecessarily when suspending and removes valid
sessions which could be restored. If that trap doesn't
remove the session on suspend, next resume goes thru
fine.

2. at line 880 in nxserver:

session_fail $uniqueid
...
exit 1

removes valid sessions (after a timeout of 10 seconds)
which could be restored by just retrying on the client
side. I think its just OK to timeout and not remove
the session in this case, and let the client retry. If
I remove this (rather incomplete) error handling code,
the only side effect is that the client gets a
timeout. When the client retries, it resumes the
suspended session fine.

After fixing these lines, I can suspend/resume the
session with much more reliability, the kind we need.
Moreover, combined with the other patch I posted for
visuals, this suspend-resume now works across linux
and windows started sessions and works amazingly well,
so far it hasn't failed to resume even once.

Fabian, can you please have a look at these and do the
needful.

Thanks,
Sunil
PS: This completes my series of long emails...;-)


--- Sunil <funtoos at yahoo.com> wrote:

> Hi,
> 
> After much fiddling for failed resumes, I realised
> that the timeout values may be too small in certain
> places. My resume works everytime if I have these
> changes in nxnode and nxserver, otherwise its a hit
> or
> miss kind of deal:
> 
> $ diff  nxnode.4.3 nxnode
> 429c429
> <                           sleep 10
> ---
> >                           sleep 60
> 
> $ diff  nxserver.4.3 nxserver
> 869c869
> <       (sleep 10; exit 1) &
> ---
> >       (sleep 60; exit 1) &
> 
> Fixed value sleeps are evil because one value works
> on
> one machine and doesn't on another. For machine
> local
> synchronization, shouldn't we use something other
> than
> sleep?
> 
> Thanks,
> Sunil
> 
> 
> 		
> ____________________________________________________
> Start your day with Yahoo! - make it your home page 
> http://www.yahoo.com/r/hs 
>  
> _______________________________________________
> FreeNX-kNX mailing list
> FreeNX-kNX at kde.org
> https://mail.kde.org/mailman/listinfo/freenx-knx
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com