D27655: Open all URLs in command line arguments

Abdel-Rahman Abdel-Rahman noreply at phabricator.kde.org
Wed Mar 25 13:27:11 GMT 2020


abogical marked an inline comment as done.
abogical added inline comments.

INLINE COMMENTS

> drosca wrote in commandlineoptions.cpp:201
> const QStringList args

I can't since I need to use `QString &url` as @dfaure wanted. Thus it can't be const.

> drosca wrote in mainapplication.cpp:453
> Again no move semantics.

This will invoke a copy of the list, which is what I'm trying to avoid.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D27655

To: abogical, #falkon, drosca
Cc: dfaure, drosca, SGOrava, #falkon, falkon, allknow, grune, akilgus, siraj_qazi, saishm, anmolgautam, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20200325/8103a37a/attachment.html>


More information about the Falkon mailing list