D27655: Open all URLs in command line arguments

[David Rosca]

drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> browserwindow.cpp:320
>  
> +        for(const QUrl &url : m_startUrls) {
> +            m_tabWidget->addView(url, Qz::NT_NotSelectedTabAtTheEnd);

qAsConst(m_startUrls)

> commandlineoptions.cpp:201
>  
> -    if (parser.positionalArguments().isEmpty())
> -        return;
> -
> -    QString url = parser.positionalArguments().constLast();
> -    QFileInfo fileInfo(url);
> -
> -    if (fileInfo.exists()) {
> -        url = fileInfo.absoluteFilePath();
> -    }
> -
> -    if (!url.isEmpty() && !url.startsWith(QLatin1Char('-'))) {
> -        ActionPair pair;
> -        pair.action = Qz::CL_OpenUrl;
> -        pair.text = url;
> -        m_actions.append(pair);
> +    QStringList args = parser.positionalArguments();
> +    for (QString &url : args) {

const QStringList args

> mainapplication.cpp:453
>  
> -    BrowserWindow* window = new BrowserWindow(type, startUrl);
> +    BrowserWindow *window = new BrowserWindow(type, std::move(startUrls));
>      connect(window, &QObject::destroyed, this, &MainApplication::windowDestroyed);

Again no move semantics.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D27655

To: abogical, #falkon, drosca
Cc: dfaure, drosca, SGOrava, #falkon, falkon, allknow, grune, akilgus, siraj_qazi, saishm, anmolgautam, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20200325/4d020d4b/attachment.html>