D27655: Open all URLs in command line arguments

David Faure noreply at phabricator.kde.org
Sun Mar 22 19:51:11 GMT 2020


dfaure added inline comments.

INLINE COMMENTS

> abogical wrote in browserwindow.cpp:320
> That contradicts what @drosca said:
> https://phabricator.kde.org/D27655?id=76386#inline-157609

A single takeFirst()/takeLast() is ok, but a loop over takeFirst() or takeLast() is *really* suboptimal.

My suggestion was a single take, and then a C++11 range-for.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D27655

To: abogical, #falkon, drosca
Cc: dfaure, drosca, SGOrava, #falkon, falkon, allknow, grune, akilgus, siraj_qazi, saishm, anmolgautam, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20200322/925a850c/attachment.html>


More information about the Falkon mailing list