D27655: Open all URLs in command line arguments

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> browserwindow.cpp:320
>  
> +        while (!m_startUrls.isEmpty()) {
> +            m_tabWidget->addView(m_startUrls.takeFirst(), Qz::NT_NotSelectedTabAtTheEnd);

range-for would be faster than modifying m_startUrls at each iteration.

If you use range-for, remember to qAsConst(m_startUrls)

> commandlineoptions.cpp:202
> +    const QStringList args = parser.positionalArguments();
> +    for (QString url : args) {
> +        QFileInfo fileInfo(url);

const QString &url

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D27655

To: abogical, #falkon, drosca
Cc: dfaure, drosca, SGOrava, #falkon, falkon, allknow, grune, akilgus, siraj_qazi, saishm, anmolgautam, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20200322/586cd15d/attachment.html>