D28153: BUG 414295

[Yehor Tsyba]

malibushko created this revision.
malibushko added a reviewer: SGOrava.
malibushko added a project: Falkon.
Herald added a subscriber: falkon.
malibushko requested review of this revision.

REVISION SUMMARY
  BUG 414295
  The problem is some sites does not provide 'name' HTML attribute for form inputs.
  The folliwng attribute is required for 'completeFormData' Falkon script, but
  if the name is empty, the key (see source code) is also empty, and the expression
  (name == key) is always evaluates to true, which leads to misfilling the form.
  To fix this we just need to check that 'name' is not empty.
  To test enter https://my.amfoss.in/login (enter somethink and click save). There must not be any fields filled.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D28153

AFFECTED FILES
  src/lib/tools/scripts.cpp

To: malibushko, SGOrava
Cc: falkon, allknow, grune, akilgus, siraj_qazi, saishm, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20200320/0bc3d987/attachment-0001.html>