D27655: Open all URLs in command line arguments

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> mainapplication.cpp:344
>  
> -    BrowserWindow* window = createWindow(Qz::BW_FirstAppWindow, startUrl);
> +    BrowserWindow* window = createWindow(Qz::BW_FirstAppWindow, std::move(startUrls));
>      connect(window, SIGNAL(startingCompleted()), this, SLOT(restoreOverrideCursor()));

`BrowserWindow *window`

> mainapplication.cpp:447
> +
> +BrowserWindow* MainApplication::createWindow(Qz::BrowserWindowType type, QList<QUrl> &&startUrls)
>  {

Same here, no move semantics.

> mainapplication.cpp:453
>  
> -    BrowserWindow* window = new BrowserWindow(type, startUrl);
> +    BrowserWindow* window = new BrowserWindow(type, std::move(startUrls));
>      connect(window, &QObject::destroyed, this, &MainApplication::windowDestroyed);

`BrowserWindow *window`

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D27655

To: abogical, #falkon, drosca
Cc: drosca, SGOrava, #falkon, falkon, grune, akilgus, siraj_qazi, saishm, anmolgautam, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20200306/0d2f22fd/attachment.html>