D27691: Be able to launch a new non-private window from a private window

[David Rosca]

drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> mainapplication.cpp:455
>  
> +void MainApplication::createNonPrivateWindow(Qz::BrowserWindowType type, const QUrl& startUrl)
> +{

Rename to `openNonPrivateWindow` because it doesn'r return BrowserWindow.

> mainapplication.cpp:457
> +{
> +    if(isPrivate()){
> +        if(isRunning()) sendMessage(QSL("ACTION:NewWindow"));

Coding style + early return (same in start private browsing).

  if (!isPrivate()) {
      createWindow(...);
      return;
  }

> mainapplication.cpp:458
> +    if(isPrivate()){
> +        if(isRunning()) sendMessage(QSL("ACTION:NewWindow"));
> +        else {

`QtSingleApplication::isRunning` only tests if the same instance of Falkon is already running, and it makes sense to test it only during startup. In this case it will always return false.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D27691

To: abogical, #falkon, drosca
Cc: drosca, falkon, #falkon, grune, akilgus, siraj_qazi, saishm, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20200306/4bb5a3fe/attachment.html>