D26932: Prompt user when KWallet is disabled

Juraj Oravec noreply at phabricator.kde.org
Mon Jan 27 16:20:16 GMT 2020


SGOrava added inline comments.

INLINE COMMENTS

> kwalletpasswordbackend.cpp:176
> +{
> +        QMessageBox msgBox;
> +        msgBox.setText("KWallet is disabled, please enable it to save your password");

Here I wonder.
Why did you choose messagebox ?

> kwalletpasswordbackend.h:44
>      void updateLastUsed(PasswordEntry &entry) override;
> -
> +    void showPrompt();
>      void removeEntry(const PasswordEntry &entry) override;

This should be a private function.

REVISION DETAIL
  https://phabricator.kde.org/D26932

To: puneethchanda, SGOrava
Cc: alukichev, falkon, grune, akilgus, siraj_qazi, saishm, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20200127/0c5c58ae/attachment-0001.html>


More information about the Falkon mailing list