D26872: Fix crash when KWallet is not available.

David Rosca noreply at phabricator.kde.org
Thu Jan 23 16:57:08 GMT 2020


drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kwalletpasswordbackend.cpp:101
> +    if (!m_wallet) {
> +        qWarning() << "KWallet disabled.";
> +        return false;

No reason for this warning.

Also I think it would be just better to change the `initialize` to `bool initialize()` and then check everywhere

  if (!initialize()) {
     return;
  }

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D26872

To: puneethchanda, SGOrava, drosca
Cc: drosca, falkon, grune, akilgus, siraj_qazi, saishm, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20200123/b6e54972/attachment.html>


More information about the Falkon mailing list