D26872: fix crash when remember password is clicked

Juraj Oravec noreply at phabricator.kde.org
Thu Jan 23 15:12:39 GMT 2020


SGOrava added inline comments.

INLINE COMMENTS

> kwalletpasswordbackend.cpp:84
>      initialize();
> -
> +    if(!m_wallet){
> +        qWarning()<<"KWallet disabled";

The should be a space after the if and before the block start

  if (condition) {
  //something
  }

> kwalletpasswordbackend.cpp:91
>      stored.updated = QDateTime::currentDateTime().toTime_t();
> -
> -    m_wallet->writeEntry(stored.id.toString(), encodeEntry(stored));
> -    m_allEntries.append(stored);
> +    if(m_wallet){
> +        m_wallet->writeEntry(stored.id.toString(), encodeEntry(stored));

There is no need to check again here because this should always be true when the code gets here.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D26872

To: puneethchanda, SGOrava
Cc: falkon, grune, akilgus, siraj_qazi, saishm, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20200123/0d372683/attachment-0001.html>


More information about the Falkon mailing list