D28549: Describe error when querying Firefox places.sqlite for bookmarks
Abdel-Rahman Abdel-Rahman
noreply at phabricator.kde.org
Sat Apr 4 04:07:36 BST 2020
abogical created this revision.
abogical added a reviewer: Falkon.
Herald added a subscriber: falkon.
Herald added a project: Falkon.
abogical requested review of this revision.
REVISION SUMMARY
Firefox places.sqlite database can still be opened even when Firefox is
running. However, it can't query the database, leaving an unhelpful
"No query Unable to fetch row" error after a long busy wait on the
database. This commit removes the busy wait and gives a more helpful
error.
TEST PLAN
1. Run Firefox.
2. Attempt to import bookmarks to Falkon.
Expect an error asking if Firefox is still running.
REPOSITORY
R875 Falkon
BRANCH
firefox-running-warn
REVISION DETAIL
https://phabricator.kde.org/D28549
AFFECTED FILES
src/lib/bookmarks/bookmarksimport/firefoximporter.cpp
To: abogical, #falkon
Cc: falkon, allknow, grune, akilgus, siraj_qazi, saishm, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20200404/bffff797/attachment.html>
More information about the Falkon
mailing list