D21304: VerticalTabs: Corectly recognize tree collapse / expand button

Juraj Oravec noreply at phabricator.kde.org
Mon May 20 13:51:37 BST 2019


SGOrava created this revision.
SGOrava added a reviewer: Falkon.
Herald added a subscriber: falkon.
Herald added a project: Falkon.
SGOrava requested review of this revision.

REVISION SUMMARY
  In treeview when the tab has no children the collapse / expand button
  is not visible but the control logic still thought that is is.
  By clicking on place where this button normaly is nothing happens
  and user has to click again somewhere else to change the selected tab.

TEST PLAN
  In treeview mode check the function of collapse / expand button when visible and invisible.
  
  - Visible: Expand / collapse the tree
  - Not visible: Select tab

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D21304

AFFECTED FILES
  src/plugins/VerticalTabs/tabtreeview.cpp

To: SGOrava, #falkon
Cc: falkon, pshaw, siraj_qazi, saishm, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20190520/9f005159/attachment.html>


More information about the Falkon mailing list