D20022: Added focus for searchbar in history sidebar & bookmark sidebar

[David Rosca]

drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  One unexpected thing is that it will also focus search line when opening new browser window, not just when manually opening sidebar.

INLINE COMMENTS

> bookmarkssidebar.cpp:53
> +{
> +    ui->search->setFocus();
> +} 

I don't really think there needs to be new method for just this one line.

> bookmarkssidebar.cpp:54
> +    ui->search->setFocus();
> +} 
> +

There is a space after `}`

> bookmarkssidebar.h:40
>      explicit BookmarksSidebar(BrowserWindow* window, QWidget* parent = 0);
> +    void showEvent(QShowEvent* event);
> +    void focusSearchLine();

It should be override.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D20022

To: saishm, #falkon, drosca
Cc: SGOrava, falkon, #falkon, siraj_qazi, saishm, anmolgautam, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20190329/ff7b61a8/attachment.html>