D21664: Vertical Tabs: Add child tab with middle click on "New Tab" button

[David Rosca]

drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> verticaltabswidget.cpp:209
> +    WebTab *tab = m_window->tabWidget()->webTab();
> +    m_window->addTab();
> +    m_window->tabWidget()->webTab()->setParentTab(tab);

This should use TabWidet::addView, so you can get the WebTab* as return value.

It would work as it is now, but if the `addTab` is ever changed, it can brake.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D21664

To: SGOrava, #falkon, drosca
Cc: drosca, falkon, siraj_qazi, saishm, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20190609/f3dd859c/attachment.html>