D15832: fixed build for qt versions < 5.11

David Rosca noreply at phabricator.kde.org
Sat Sep 29 15:23:43 BST 2018


drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  Also please fix build on FreeBSD: https://build.kde.org/job/Extragear/job/falkon/job/kf5-qt5%20FreeBSDQt5.11/6/console

INLINE COMMENTS

> qmlwebengineurlrequestjob.cpp:63
> +#if QT_VERSION >= QT_VERSION_CHECK(5, 11, 0)
>  QString QmlWebEngineUrlRequestJob::initiator() const
>  {

Just make it return empty QString when built against QtWebEngine < 5.11.
Also it should check the QtWebEngine version, not QT_VERSION.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D15832

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180929/47ea2063/attachment.html>


More information about the Falkon mailing list