D14774: Add QML Extensions API

David Rosca noreply at phabricator.kde.org
Mon Sep 24 15:18:06 BST 2018


drosca added inline comments.

INLINE COMMENTS

> anmolgautam wrote in qmlkeyevent.h:67
> Because I was returning -1 when m_keyEvent is null (But I doubt that it will not be null, since user is not creating QmlKeyEvent).
> Should I remove the check and make it quint32?

Just return 0 in that case, and yes make it quint32 again.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14774

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180924/9a2fc3cf/attachment.html>


More information about the Falkon mailing list