D14774: Add QML Extensions API

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> anmolgautam wrote in qmlextensionscheme.cpp:31
> Sorry, I didn't get you. Can you please elaborate? Why `QJSValue`?  Its meant to be like the QML way and not JS function -
> 
>   requestStarted: {
>       var url = request.url
>       ...
>   }

We already discussed this in previous review.
Unless it is passed as `QJSValue` (from `QJSEngine::newQObject`) to QML engine it won't be correctly released.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14774

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180923/ac8b016e/attachment.html>