D14774: Add QML Extensions API

[Anmol Gautam]

anmolgautam marked 3 inline comments as done.
anmolgautam added inline comments.

INLINE COMMENTS

> drosca wrote in plugins.cpp:423
> Why is it duplicated there?

to get the settings path `m_settingsPath = DataPaths::currentProfilePath() + QL1S("/extensions");`

> drosca wrote in qmlbrowseraction.h:37
> What is identity?

qobject id of the button, but since id will have name collision with id (in qml) so you had suggested me to use it by name 'identity'

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14774

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180917/b632f78b/attachment.html>