D14775: Added tests for QML Extension API

[David Rosca]

drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> qmlcookiesapitest.cpp:111
> +    // a solution is to convert both to string, but this is not the best solution
> +    QCOMPARE(mangoCookie->property("expirationDate").toDateTime().toString(), current.addSecs(120).toString());
> +

If this check doesn't pass then why it is there at all?
If you can't ensure the time will be identical then compare it with some tolerance (eg. 1s).

> qmlwindowsapitest.cpp:50
> +    QCOMPARE(mApp->windowCount(), 2);
> +    // FIXME: signal is emitted 2 times here -
> +    // 1st for the initial window, 2nd for the created window

So is it correct or not?

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14775

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180902/d8179d23/attachment.html>