D16238: Replace Qt foreach with C++ foreach

David Rosca noreply at phabricator.kde.org
Tue Oct 23 16:40:38 BST 2018


drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  You should always use `for` on const Qt containers, as otherwise it will detach.
  So it should be:
  
    const auto tabs = allTabs(false);
    for (WebTab *tab : tabs) {
    ...
    }

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D16238

To: pflynn, drosca
Cc: falkon, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20181023/edc3a7de/attachment.html>


More information about the Falkon mailing list