D12833: Fix the fix for #391300 to require only QtWebEngine 5.10, not Qt 5.10

David Rosca noreply at phabricator.kde.org
Sat May 12 11:53:32 BST 2018


drosca added a comment.


  In D12833#261316 <https://phabricator.kde.org/D12833#261316>, @kkofler wrote:
  
  > Also, all the existing macros in `config.h.cmake` are `#cmakedefine`, not `#cmakedefine01`, so are you sure you want the latter even though it would be inconsistent?
  
  
  Yes, the other ones were ported from qmake, but new defines should use cmakedefine01 as that will also produce warning when forgetting including config.h header, instead of just silently ignoring it.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D12833

To: kkofler, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180512/df1b8131/attachment.html>


More information about the Falkon mailing list