D12833: Fix the fix for #391300 to require only QtWebEngine 5.10, not Qt 5.10

Kevin Kofler noreply at phabricator.kde.org
Sat May 12 02:33:16 BST 2018


kkofler created this revision.
kkofler added a reviewer: drosca.
kkofler added a project: Falkon.
Restricted Application added a subscriber: falkon.
kkofler requested review of this revision.

REVISION SUMMARY
  QtWebEngine can be newer than the rest of Qt (e.g., on Fedora 27).
  
  This fixes the version check in WebView::savePageAs to use a macro
  defined in CMakeLists.txt based on the version of QtWebEngineWidgets
  rather than relying on QT_VERSION, which is the version of QtCore.
  
  CCBUG: 391300

TEST PLAN
  Fedora 27 build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1081337

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D12833

AFFECTED FILES
  CMakeLists.txt
  src/lib/webengine/webview.cpp

To: kkofler, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180512/086ce9fb/attachment.html>


More information about the Falkon mailing list