D12666: Use security state icon in popup location bar

[David Rosca]

drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> popuplocationbar.h:49
>      void showSiteIcon();
> +    void setPrivacyState(const bool &state);
>  

Just `bool state`, you should not use const-ref for POD (plain old data) types.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D12666

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180502/84296db3/attachment.html>