D11664: added support for Drag (on) and Drop (off) the bookmark toolbar

[David Rosca]

drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> anmolgautam wrote in bookmarkitem.h:31
> sure not needed, I was just overthinking

But that was meant also to the QObject subclass, it's not needed.

> bookmarkstoolbar.cpp:313
> +        BookmarksToolbarButton* button = buttonAt(m_dropPos);
> +        if (button->bookmark()->isFolder()) {
> +            return;

What if `button == nullptr`, you check for it few lines bellow this but not here.

> bookmarkstoolbar.cpp:329
> +
> +    QWidget::paintEvent(p);
> +}

It has to call QWidget::paintEvent(p) as the first thing in this method, otherwise it could just paint over the drop indicator.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D11664

To: anmolgautam, drosca, #falkon
Cc: falkon, herrold, ixoos, anmolgautam, iodelay, spoorun, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180331/2c5942f2/attachment.html>