D11328: Added check for duplicate bookmarks

[David Rosca]

drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.
Restricted Application added a subscriber: falkon.

INLINE COMMENTS

> bookmarkstools.cpp:151
> +
> +    if (Bookmarks().isBookmarked(url)) {
> +        QLabel* warning_label = new QLabel(dialog);

As discussed on IRC, please only leave this part in the patch.

> bookmarkstools.cpp:152
> +    if (Bookmarks().isBookmarked(url)) {
> +        QLabel* warning_label = new QLabel(dialog);
> +        warning_label->setText(Bookmarks::tr("<b>NOTE:</b> This site is already bookmarked"));

`warningLabel` or just `label`

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D11328

To: anmolgautam, #falkon, drosca
Cc: falkon, herrold, ixoos, anmolgautam, iodelay, spoorun, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180330/b4d86bc4/attachment.html>