D14155: [Feature] Add python plugin MiddleClickLoader

[David Rosca]

drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  Looks good, but please rename the folder to lowercase `middleclickloader`.

INLINE COMMENTS

> mcl_settings.ui:59
> +       <property name="text">
> +        <string>Open url at:</string>
> +       </property>

Open url in

> mcl_settings.ui:77
> +     <item>
> +      <widget class="QComboBox" name="comboBox"/>
> +     </item>

Should use more descriptive name than just "comboBox".

> mcl_settings.ui:82
> +   <item>
> +    <widget class="QCheckBox" name="checkBox">
> +     <property name="text">

Same here, better name.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14155

To: SGOrava, #falkon, drosca
Cc: falkon, tuomisto, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180716/a9a6beab/attachment.html>