D14774: Add QML Extensions API
David Rosca
noreply at phabricator.kde.org
Sat Aug 18 13:01:08 BST 2018
drosca added inline comments.
INLINE COMMENTS
> qmli18n.cpp:34
> + const char* language = getenv("LANGUAGE");
> + qputenv("LANGUAGE", QLocale::system().name().toUtf8());
> + bindtextdomain(m_domain.toUtf8(), localeDir.toUtf8());
This is Qt, so no `getenv`. You should use `qEnviornmentVariableIsSet`.
REPOSITORY
R875 Falkon
REVISION DETAIL
https://phabricator.kde.org/D14774
To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180818/ae58a31b/attachment.html>
More information about the Falkon
mailing list