D14774: Add QML Extensions API

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> qmli18n.cpp:37
> +    if (language.isEmpty()) {
> +        qunsetenv("LANGUAGE");
> +    } else {

This still doesn't work, did you actually test the code before uploading it?

`if (language.isEmpty()) {` this will be true also when the variable is just set without any value (eg. `LANGUAGE="" falkon`)

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14774

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180818/102f6daa/attachment.html>