D14774: Add QML Extensions API

David Rosca noreply at phabricator.kde.org
Fri Aug 17 16:33:33 BST 2018


drosca added inline comments.

INLINE COMMENTS

> qmli18n.cpp:33
> +    QString localeDir = QStandardPaths::locate(QStandardPaths::GenericDataLocation, "locale", QStandardPaths::LocateDirectory);
> +    QByteArray language = qgetenv("LANGUAGE");
> +    qputenv("LANGUAGE", QLocale::system().name().toUtf8());

`const`

It should also check if the env var was actually set, before trying to reset it.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14774

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180817/cd95fc26/attachment.html>


More information about the Falkon mailing list