D14513: Add QML Extensions API

David Rosca noreply at phabricator.kde.org
Fri Aug 10 18:01:29 BST 2018


drosca added inline comments.

INLINE COMMENTS

> anmolgautam wrote in qmlbrowseraction.h:164
> Its not designed to be initialized explicitly, but checks must be added in setIcon where it can be null eq in `auto qmlEngine = qobject_cast<QmlEngine*>(m_popup->creationContext()->engine());`

Sorry, that was meant for `m_locations`, one line above.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14513

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180810/c752d875/attachment.html>


More information about the Falkon mailing list