D14519: Added HelloQml Extension

David Rosca noreply at phabricator.kde.org
Thu Aug 2 17:36:16 BST 2018


drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  It's missing Messages.sh script for extracting translatable strings (it also seems it doesn't use translations at all).
  
  It is also very basic, it should use more functionality. What would be great is an example extension <-> webpage bridge = extension scheme + registering extra objects.

INLINE COMMENTS

> CMakeLists.txt:15
> +        DIRECTORY ${name}
> +        DESTINATION "${FALKON_INSTALL_PLUGINDIR}/qml"
> +    )

Should also exclude Messages.sh

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14519

To: anmolgautam, drosca
Cc: falkon, tuomisto, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180802/5dee7e64/attachment.html>


More information about the Falkon mailing list