D12522: prevent ssl error dialog by website domain

[David Rosca]

drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  This is wrong, it would accept **all** certificate errors triggered by one page, regardless of what error it is - it may even be error with completely different certificate, from different resource on page. If anything, this should only be offered to reject all certificate errors from one page, but even then it doesn't really make sense.
  
  What should be done to fix that bug is to offer `NoForThisSession` similar to `OnlyForThisSession` with same logic. Event this logic is not really correct due to very limited QtWebEngine API here, but is good enough to be used for one browsing session (it only stores url and certificate error type).

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D12522

To: anmolgautam, drosca, #falkon
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180425/9b32c4db/attachment.html>