exiv2 issue

[Maik Qualmann]

Hi Gilles,

With this commit, both Exiv2 CMake variants should now be recognized and each 
one should be used.

https://invent.kde.org/graphics/digikam/-/commit/
dbf6b33f93b73b9f73e80eb4ed82bda43c83ad53

Best

Maik

Am Donnerstag, 9. November 2023, 17:15:39 CET schrieb Gilles Caulier:
> Maik,
> 
> Under the MXE tool-chain, Exiv2 0.27.7 is well detected :
> 
> -- Found LibExiv2:
> /mnt/data/build.win64/usr/x86_64-w64-mingw32.shared/lib/libexiv2.dll.a
> (found version "0.27.7")
> 
> Gilles
> 
> Le jeu. 9 nov. 2023 à 16:51, Gilles Caulier <caulier.gilles at gmail.com> a 
écrit :
> > Maik,
> > 
> > Look like the version of Exiv2 is not detected at all under Windows
> > with VCPKG. I cleaned the build directory of digiKam and started cmake
> > config again. It's clear that version info is empty :
> > 
> > -- Found LibExiv2: E:/dk/x64-windows/lib/exiv2.lib (found version "..")
> > 
> > CMake Error at core/cmake/rules/RulesLibExiv2.cmake:18 (message):
> >   Exiv2 version is too old (..)! Minimal version required:0.27.1.
> > 
> > Call Stack (most recent call first):
> >   core/CMakeLists.txt:72 (include)
> > 
> > Gilles
> > 
> > Le jeu. 9 nov. 2023 à 16:43, Gilles Caulier <caulier.gilles at gmail.com> a 
écrit :
> > > Maik,
> > > 
> > > Under MacOS with Exiv2 0.28.1, the compilation pass without problem.
> > > 
> > > Gilles
> > > 
> > > Le jeu. 9 nov. 2023 à 14:24, <leoutation at gmx.fr> a écrit :
> > > > On 11/9/23 08:02, Maik Qualmann wrote:
> > > > > The compilation problems are now fixed in git/master.
> > > > 
> > > > Compilation  is fixed now for me. Thanks
> > > > 
> > > > > Maik
> > > > > 
> > > > > Am Mittwoch, 8. November 2023, 21:13:28 CET schrieb 
leoutation at gmx.fr:
> > > > >> On 11/8/23 19:53, Maik Qualmann wrote:
> > > > >>> Apart from you compiling problem, Exiv2 has nothing to do with
> > > > >>> displaying
> > > > >>> layers in XCF files.
> > > > >> 
> > > > >> OK, i have to try to build first.
> > > > >> Here full error message:
> > > > >> 
> > > > >> -- Configuring done (38.0s)
> > > > >> CMake Error at core/libs/metadataengine/CMakeLists.txt:106
> > > > >> 
> > > > >> (include_directories):
> > > > >>     Error evaluating generator expression:
> > > > >>       $<TARGET_PROPERTY:exiv2lib,INTERFACE_INCLUDE_DIRECTORIES>
> > > > >>     
> > > > >>     Target "exiv2lib" not found.
> > > > >> 
> > > > >> CMake Error at core/libs/metadataengine/CMakeLists.txt:106
> > > > >> 
> > > > >> (include_directories):
> > > > >>     Error evaluating generator expression:
> > > > >>       $<TARGET_PROPERTY:exiv2lib,INTERFACE_INCLUDE_DIRECTORIES>
> > > > >>     
> > > > >>     Target "exiv2lib" not found.
> > > > >>> 
> > > > >>> Maik
> > > > >>> 
> > > > >>> Am Mittwoch, 8. November 2023, 19:00:03 CET schrieb 
leoutation at gmx.fr:
> > > > >>>> On 11/8/23 18:45, Gilles Caulier wrote:
> > > > >>>>> Hi,
> > > > >>>>> 
> > > > >>>>> Clean up the build dir properly. It's known that Exiv2 can be
> > > > >>>>> problematic when upgrading the library.
> > > > >>>> 
> > > > >>>> I did it, i get same issue
> > > > >>>> 
> > > > >>>>> Take care also about the headers files available. Do not mix 2
> > > > >>>>> different versions of the library. It's known that Exiv2 does
> > > > >>>>> not
> > > > >>>>> support this kind of usage.
> > > > >>>> 
> > > > >>>> I have only exiv2 and libgexiv2 (Gimp depend)  installed on my
> > > > >>>> system
> > > > >>>> 
> > > > >>>>> Best
> > > > >>>>> 
> > > > >>>>> Gilles Caulier
> > > > >>>>> 
> > > > >>>>> Le mer. 8 nov. 2023 à 18:42, <leoutation at gmx.fr> a écrit :
> > > > >>>>>> Hi
> > > > >>>>>> I get CMake error when building digikam git
> > > > >>>>>> 'Target "exiv2lib" not found'
> > > > >>>>>> But exiv2 is installed on my Arch system
> > > > >>>>>> https://archlinux.org/packages/extra/x86_64/exiv2/
> > > > >>>>>> version: exiv2 0.28.1-1  /usr/include/exiv2/exiv2lib_export.h
> > > > >>>>>> To know: i suspect this exiv2 version causing  issue (1) with
> > > > >>>>>> XCF
> > > > >>>>>> files,
> > > > >>>>>> that's why i try to build again digikam git.
> > > > >>>>>> (1) Digikam git doesn't display layers in XCF files
> > > > >>>>>> 
> > > > >>>>>> --
> > > > >>>>>> Maderios
> > > > >>>> 
> > > > >>>> --
> > > > >>>> Maderios
> > > > >> 
> > > > >> --
> > > > >> Maderios
> > > > 
> > > > --
> > > > Maderios